Merged
Conversation
… to the millepede file
…es. Added Volumes, Tracker and double sensors structures
…ntStructuresBuilder. Removed .root files dumped by SimpleGBLTrajAliDriver and KalmanToGBLDriver. Fixed Locale in BuildMillepedeCompact
Characterize E/p for tracks having hits in all 14 sensors to aid in alignment studies using momentum constraints. Need to be careful using clusters near the edge of the calorimeter or next to dead crystals.
JeremyMcCormick
previously requested changes
Jun 7, 2021
normangraf
requested changes
Jun 9, 2021
Contributor
normangraf
left a comment
There was a problem hiding this comment.
This adds needed functionality.
All the tests run successfully to completion.
I concur with @JeremyMcCormick's request to move the script.
Once that is done I see no reason not to proceed.
cbravo135
approved these changes
Jun 10, 2021
Collaborator
cbravo135
left a comment
There was a problem hiding this comment.
IMO, time could be saved when there is a request by this if the reviewer just does the little trivial move themselves if they feel so strongly about it. The move is done.
normangraf
approved these changes
Jun 10, 2021
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Looks good.
All test run successfully to completion.
Looking forward to seeing results from this update.
Stale review, changes were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge alignment developments into Master branch