Conversation
… updates to log messsages
normangraf
left a comment
There was a problem hiding this comment.
I've not explicitly run this, but the existing tests run to completion and it adds needed functionality.
Please proceed.
| String[] flagNames = {"svt_bias_good", "svt_position_good", "svt_burstmode_noise_good", "svt_event_header_good", "svt_latency_good", "svt_readout_overlap_good"}; | ||
| private static Level LEVEL = Level.WARNING; | ||
|
|
||
| String[] flagNames = {"svt_bias_good", "svt_position_good", "svt_burstmode_noise_good", "svt_event_header_good", "svt_latency_good"}; |
There was a problem hiding this comment.
I think this will break the apv25 readout crosstalk filter.
There was a problem hiding this comment.
It doesn't look like it does as this gets overwritten by the steering file. Is there a reason for removing "svt_readout_overlap_good" from this here though? I would prefer we just keep it so a list of all possible flags is kept here.
There was a problem hiding this comment.
This should be fixed now. I reverted the flag names array.
|
Unintentional change - I will revert it.
…On Fri, May 28, 2021 at 6:22 PM Cameron Bravo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In recon/src/main/java/org/hps/recon/filtering/EventFlagFilter.java
<#868 (comment)>:
> @@ -10,8 +11,9 @@
public class EventFlagFilter extends EventReconFilter {
private static Logger LOGGER = Logger.getLogger(EventFlagFilter.class.getPackage().getName());
-
- String[] flagNames = {"svt_bias_good", "svt_position_good", "svt_burstmode_noise_good", "svt_event_header_good", "svt_latency_good", "svt_readout_overlap_good"};
+ private static Level LEVEL = Level.WARNING;
+
+ String[] flagNames = {"svt_bias_good", "svt_position_good", "svt_burstmode_noise_good", "svt_event_header_good", "svt_latency_good"};
It doesn't look like it does as this gets overwritten by the steering
file. Is there a reason for removing "svt_readout_overlap_good" from this
here though? I would prefer we just keep it so a list of all possible flags
is kept here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQXV47ZZQ4YVYIVJAY7EDDTQAQSHANCNFSM45VFLSVQ>
.
|
cbravo135
left a comment
There was a problem hiding this comment.
Mostly additions to the code only slightly touching code that already existed. I also ran reco on a 2019 evio file and didn't see any obvious issues.
This is the currently working version of the online recon and monitoring tools, as described in several software meeting presentations, resolving #733.
These changes implement a server which is able to launch instances of the reconstruction which fill remote AIDA trees. These are aggregated and can be viewed in a web browser or JAS3.
A working test configuration can be found here:
https://github.com/JeremyMcCormick/hps-projects/tree/master/projects/online-recon-test
Documentation is on Confluence:
https://confluence.slac.stanford.edu/display/hpsg/Online+Reconstruction+Tools