Skip to content

Comments

Enable steering files to configure the time minimizer used in RawTrackerHitFitterDriver#866

Merged
cbravo135 merged 4 commits intomasterfrom
iss371
May 25, 2021
Merged

Enable steering files to configure the time minimizer used in RawTrackerHitFitterDriver#866
cbravo135 merged 4 commits intomasterfrom
iss371

Conversation

@cbravo135
Copy link
Collaborator

PhysicsRun2019_pass0_recon_evio.lcsim was also updated to use Migrad.

@cbravo135
Copy link
Collaborator Author

Here is some output setting the minimizer to Simplex:

collection name : SVTShapeFitParameters
 parameters: 

--------------- print out of LCGenericObject collection --------------- 

  flag:  0x80000000

 [   id   ]  - isFixedSize: false
 --------------------------------------------------------
 [00001656] d:0.73; d:3.97; d:1801.36; d:472.24; d:0.63;  --------------------------------------------------------
 [00001657] d:16.01; d:7.60; d:1133.01; d:319.97; d:0.91;  --------------------------------------------------------
 [00001658] d:-4.81; d:27.76; d:129.58; d:302.63; d:0.74;  --------------------------------------------------------
 [00001659] d:-64.20; d:11.42; d:261.94; d:304.45; d:0.92;  --------------------------------------------------------
 [00001660] d:-41.39; d:nan; d:200.04; d:297.99; d:0.95;  --------------------------------------------------------
 [00001661] d:-7.46; d:nan; d:210.48; d:305.43; d:0.91;  --------------------------------------------------------

Here is some output with it set to Migrad:

collection name : SVTShapeFitParameters
parameters: 

--------------- print out of LCGenericObject collection --------------- 

 flag:  0x80000000

[   id   ]  - isFixedSize: false
--------------------------------------------------------
[00001239] d:3.18; d:2.27; d:1824.64; d:472.07; d:0.64;  --------------------------------------------------------
[00001240] d:4.27; d:1.68; d:1496.56; d:468.70; d:0.95;  --------------------------------------------------------
[00001241] d:-0.15; d:1.64; d:1433.48; d:286.65; d:0.75;  --------------------------------------------------------
[00001242] d:-83.03; d:4.21; d:1521.75; d:323.20; d:0.76;  --------------------------------------------------------
[00001243] d:18.97; d:2.46; d:1119.36; d:291.59; d:0.37;  --------------------------------------------------------
[00001244] d:-88.88; d:8.43; d:1172.00; d:292.41; d:0.62;  --------------------------------------------------------
[00001245] d:-82.87; d:5.44; d:1094.98; d:323.55; d:0.83;  --------------------------------------------------------
[00001246] d:-85.51; d:50.74; d:160.45; d:335.98; d:0.71;  --------------------------------------------------------
[00001247] d:2.32; d:2.85; d:974.56; d:281.74; d:0.36;  --------------------------------------------------------
[00001248] d:-79.99; d:12.21; d:358.74; d:302.54; d:0.88;  --------------------------------------------------------
[00001249] d:-75.31; d:8.53; d:294.86; d:284.03; d:0.97;  --------------------------------------------------------
[00001250] d:-5.21; d:8.33; d:161.07; d:238.45; d:0.77;  --------------------------------------------------------
[00001251] d:-87.86; d:5.03; d:1177.84; d:260.51; d:0.77;  --------------------------------------------------------

Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds needed functionality to our reconstruction.
All tests pass.
Please proceed.

@cbravo135 cbravo135 merged commit 7c43a2d into master May 25, 2021
@pbutti pbutti deleted the iss371 branch May 26, 2021 18:35
@cbravo135 cbravo135 linked an issue Jun 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing errors in SVT pulse time fit

3 participants