Merged
Conversation
…ECAL clusters. All some hit sharing by candidate tracks that get raised from the dead. Fixed bugs in early cuts made on seed formation, which were meant to speed up the code, and set those cuts better, based on distributions obtained from good tracks. More debug printout and histograms, and small adjustments to some default cuts, including addition of two seed strategies.
normangraf
approved these changes
May 10, 2021
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Looks good. Please proceed.
Collaborator
|
Are there any studies that show what these changes do? Where can I read about these problems and how this proposed solution fixes them. I don't think this has been discussed with much of a audience yet. |
omar-moreno
approved these changes
May 11, 2021
Contributor
Author
|
Yo Cam, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix on preliminary cuts on search strategies.