Conversation
…ixed the field map not to return 0 for points outside the limits in x (was producing NaN results on some tracks).
|
This branch is quite a bit behind master at the moment. Please consider pulling master and rerunning your checks to make sure everything is still good after merging in the current master. git will be able to merge automatically via the normal recursive strategy, so don't worry about that (I already did this). I am currently running a few checks of this myself. |
|
Hi Cam, Thank you for checking this! |
cbravo135
left a comment
There was a problem hiding this comment.
I ran a few files with this and iss837, and master all merged. Look reasonable to me. I also checked that is passes the integration tests.
|
The results from running on the 2019 sample partitions, currently at https://www.slac.stanford.edu/~bravo/KF_vs_GBL_Tight_pBot_2019/KF_vs_GBL_Tight_pBot_2019.html use these three commits. |
normangraf
left a comment
There was a problem hiding this comment.
This adds new functionality and fixes a few known issues.
Does not affect legacy reconstruction.
Code builds and tests pass.
Please proceed.
Kalman dev