Conversation
|
Looking forward to testing this. Can you give a presentation at the recon meeting 4/13? |
|
I'll try to! |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <lcdd xmlns:lcdd="http://www.lcsim.org/schemas/lcdd/1.0" xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" xs:noNamespaceSchemaLocation="http://www.lcsim.org/schemas/lcdd/1.0/lcdd.xsd"> | ||
| <header> | ||
| <detector name="HPS_SurAliUCMS_ForProd_BOTAlign_iter9" /> |
There was a problem hiding this comment.
Do these detector names need to be the same as the name of the det in the directory tree? I think this would just require regenerating this lcdd with the compact from this directory?
There was a problem hiding this comment.
They don't need to, but they really should be.
There was a problem hiding this comment.
It needs to be the same since once you try to reconstruct any events simulated with this detector, it will look for the detector named in the lcdd file. It will either not be found, or the wrong detector will be picked up. And the reconstruction will most likely crash since the SimTrackerHits won't be inside the Si sensors.
There was a problem hiding this comment.
Most of the time we specify the detector anyway right? So it doesn't need to be the same.
There was a problem hiding this comment.
Anyway, I think we are all in agreement that it should be changed.
There was a problem hiding this comment.
Thank you for spotting this!
Should be fixed.
|
|
||
| <!-- | ||
| <fields> | ||
| <field type="BoxDipole" name="AnalyzingDipole" x="dipoleMagnetPositionX" y="0*cm" z="dipoleMagnetPositionZ" dx="dipoleMagnetWidth/2.0" dy="dipoleMagnetHeight/2.0" dz="dipoleMagnetLength/2.0" bx="0.0" by="constBFieldY" bz="0.0" /> |
There was a problem hiding this comment.
I don't think we need to leave this here. Just remove it.
|
|
||
| <!-- Sensor position survey --> | ||
|
|
||
| <!-- For 2019 only the front sensors L1, L2, L3 and L4 have been surveyed --> |
There was a problem hiding this comment.
Do we need to keep the old survey positions for any reason? Aren't they in an older compact? Maybe it's best to just delete this too.
There was a problem hiding this comment.
Hey Omar,
I need the old positions for the back of the detector.
normangraf
left a comment
There was a problem hiding this comment.
Looks good. Adds new functionality.
cbravo135
left a comment
There was a problem hiding this comment.
Great to see a new detector alignment after the strip mapping bug was fixed!
Pass0 aligned detector for testing.
TO DO:
However much better Chi2 and track parameters as a whole for studying track reconstruction cuts and algorithms.