Skip to content

Comments

Allow running reconstruction starting from fitted hits#703

Merged
pbutti merged 11 commits intomasterfrom
iss701
Apr 23, 2020
Merged

Allow running reconstruction starting from fitted hits#703
pbutti merged 11 commits intomasterfrom
iss701

Conversation

@omar-moreno
Copy link
Collaborator

No description provided.

@omar-moreno omar-moreno added this to the V4.5 milestone Apr 22, 2020
@omar-moreno omar-moreno self-assigned this Apr 22, 2020
@omar-moreno
Copy link
Collaborator Author

I still need to make a couple of minor changes so please hold off on merging.

I wanted to put the PR up for people to start testing.

@normangraf
Copy link
Contributor

Current tests all pass.

@pbutti
Copy link
Contributor

pbutti commented Apr 23, 2020

Tested iss701 locally with the feature off and on. Validated that:

  • Creates the same SiClusters1D collection size and global location
  • Tracks have the same track parameters in each events

Copy link
Contributor

@pbutti pbutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts in DataTrackerHitDriver.java

Added explicit test for RawTrackerHitDriver to test re-reconstruction from LCIO files.
@normangraf
Copy link
Contributor

I've added an explicit test for the DataTrackerHitDriver. Enabling debug and comparing the textual output confirms the exact same results. Timing for 100 events is as follows:

Driver 0 0.00ms
RawTrackerHitSensorSetup 100 24.7ms
RawTrackerHitFitterDriver 100 6.06s
DataTrackerHitDriver 100 211ms
ReadoutCleanupDriver 100 5.90ms
*self 0 -6.30e+03ms
Loop from raw processed 100 events.
rerunning from LCIO fitted hits
Driver 0 0.00ms
SensorSetup 100 17.2ms
*self 0 -17.2ms
Loop from fitted LCIO processed 100 events.
Done!

Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be good to go.

@pbutti pbutti merged commit cfcc298 into master Apr 23, 2020
@pbutti pbutti deleted the iss701 branch April 23, 2020 23:39
@JeremyMcCormick JeremyMcCormick removed this from the V4.5 milestone Feb 25, 2021
@JeremyMcCormick JeremyMcCormick added this to the v5.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants