Conversation
…ope layer patterns
…ange HodoscopePatternReadoutDriver.java: hodo patterns are added into data manageer only if there are hodo hits
…pePattern.java -> record-util/src/main/java/org/hps/readout/util/HodoscopePattern.java
… is for pairs trigger
… in the steering file with pairs trigger
…Hits. Useful for running on reco lcios
… but overrides the getHitLength method so it's usable with SiStriplets.
…Run2019TrigPulse.lcsim
normangraf
approved these changes
Mar 31, 2020
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Builds and tests fine, so at least it doesn't break anything (that we're testing...). There are a LOT of changes in this request so I think we should continue performance testing after the merge.
pbutti
approved these changes
Mar 31, 2020
Contributor
|
I cannot speak much about all the trigger part. For the recon part things look ok. Only doubt is the current settings for the "firstLayer" in the KalmanPatRecHPS that is now set to "0", probably breaking 2016 proper pattern reco at the moment. |
Contributor
|
Layering starts at 1. |
Contributor
|
It's a different numbering what I'm talking about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.