restore relevant detectors to old version#1003
restore relevant detectors to old version#1003sarahgaiser wants to merge 2 commits intoJeffersonLab:masterfrom
Conversation
|
Before merging this we should check that dumping the pre-bug-fix geometry and the adjusted geometry from the PR give the same result. |
|
Thanks for doing this. I don't see any real need for the *_fixed detectors since we should be proceeding with new and improved detectors for pass1. But I have no objections if others might find them useful. |
|
I just added the *_fixed detectors to keep track of the "original" version of those detectors in case we need them again. Did you happen to check if dumping the old and fixed geometries yields the same results? |
|
I have not checked the geometries. |
|
There are some samples made with HPS-PhysicsRun2019-v2-4pt5 too |
|
To not change existing scripts for MC/data production, I suggest to directly update the original versions without changing detector names, and copy original versions with other names, like DETNAME_original. |
|
@sarahgaiser |
tl;dr:
DETNAME_fixed: always use this version
DETNAME: only use this version if you need pre-bug-fix (wrong) geometry
To ensure that the same detector name always refers to the same geometry, I went back and adjusted the detectors pointed out by @normangraf to represent the same geometry as before the geometry bug fix (#1001). This includes removing the top back survey constants (which have previously not been used due to a typo) and introducing a 700um shift of layers 3 and 4 towards the beam. I copied the unmodified version to DETNAME_fixed which should be used from now on for further alignment and analysis work unless you want to specifically analyze MC data generated before the fix or other scenarios where you need the pre-bug-fix version of the detector.