Conversation
Collaborator
Author
|
Work with the pull request https://code.jlab.org/hallb/clas12/coatjava/networks/-/merge_requests/5 |
Collaborator
Author
|
@baltzell Hi, I think the unittest fails because it uses cvmfs to get the networks, and it is the wrong commit of the networks repo. |
Member
Makes sense, assuming cvmfs is behind. I pushed a commit to switch the relevant CI jobs to use LFS. |
Collaborator
Author
|
Thanks Chris |
Collaborator
|
Mathieu, can you describe conceptually what these changes amount to? |
Collaborator
Author
|
Sure, here is a summary. Let me know if you’d like more details: Changes in the pull request:
|
Member
sorry, could you put this in the PR description up top, please? |
Collaborator
Author
|
No problem, it's now in the first comment. |
601a7cc to
971d20e
Compare
…ers and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI)
971d20e to
3f5f733
Compare
baltzell
approved these changes
Dec 11, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
* Start an implementation for the track matching for ALERT * Fix the path for the ALERT AI models * ALERT: Improve the AI model for track finding * ALERT: Change name of the model class for the track finding * ALERT: Rename some variables and class (Mode to ModeTrackFinding) * ALERT: change superpreclusters to InterCluster * Move the track matching to the ALERT Engine * ALERT: change the structure of the AHDCEngine to write the interclusters and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI) * Fix the track matching AI and the output bank * Add the model and fix the constant loader in the ATOF * Modify HipoDataSync initialization in AHDCEngine * Update model path for TrackMatchingAI to use the new path for AI models * Remove the AI networks * Update model path for ALERT model in ModelTrackFinding * Update model path for TrackMatchingAI * fix(ci): use `--lfs` with `--unittests` --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
* Start an implementation for the track matching for ALERT * Fix the path for the ALERT AI models * ALERT: Improve the AI model for track finding * ALERT: Change name of the model class for the track finding * ALERT: Rename some variables and class (Mode to ModeTrackFinding) * ALERT: change superpreclusters to InterCluster * Move the track matching to the ALERT Engine * ALERT: change the structure of the AHDCEngine to write the interclusters and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI) * Fix the track matching AI and the output bank * Add the model and fix the constant loader in the ATOF * Modify HipoDataSync initialization in AHDCEngine * Update model path for TrackMatchingAI to use the new path for AI models * Remove the AI networks * Update model path for ALERT model in ModelTrackFinding * Update model path for TrackMatchingAI * fix(ci): use `--lfs` with `--unittests` --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the pull request: