use a new waveform classification#849
Merged
baltzell merged 3 commits intoJeffersonLab:developmentfrom Oct 2, 2025
Merged
Conversation
mathieuouillon
approved these changes
Oct 1, 2025
Collaborator
mathieuouillon
left a comment
There was a problem hiding this comment.
Look good for me. The decoding and reconstruction work.
Collaborator
|
Note, this adds potential thread-safety issues. Looks like ModeAHDC's extract already wasn't thread safe. We'll want to fix that before using this in reconstruction (meanwhile, single-threaded usage in the decoder is ok). |
Member
opened #850, so we can start testing for these types of issues |
Because the new version of the t0, published yesterday, already contains the startTime
baltzell
approved these changes
Oct 1, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a new waveform classification.
Complemented by some additional cuts at the reconstruction level, we have seen an increase of the detection efficiency.
One can refer to the study presented during the ALERT meeting on September 29, 2025: https://clasweb.jlab.org/wiki/images/b/b0/WfType-study.pdf