ALERT: Improvement made to the algorithm for generating all track candidates.#508
Merged
baltzell merged 6 commits intoJeffersonLab:developmentfrom Mar 27, 2025
mathieuouillon:development
Merged
ALERT: Improvement made to the algorithm for generating all track candidates.#508baltzell merged 6 commits intoJeffersonLab:developmentfrom mathieuouillon:development
baltzell merged 6 commits intoJeffersonLab:developmentfrom
mathieuouillon:development
Conversation
Now this option can be setup from the yaml file with the option Mode:
```
ALERT:
Mode: "AI_Track_Finding"
```
Add a cut on the number of hits to rely on the conventional track finding with there is more than 300 hits.
- Use a single thread for the inference. - Remove waring about the graph executor optimization
Member
|
pre-commit.ci job will pass once #505 is merged; sorry we may have done the pre-commit activation steps a bit out of order |
baltzell
reviewed
Mar 27, 2025
| public TrackConstruction() {} | ||
|
|
||
| /** | ||
| * Computes the modulo operation, which returns the remainder of the division |
Collaborator
There was a problem hiding this comment.
probably should be IEEERemainder
baltzell
reviewed
Mar 27, 2025
| * @param number_of_track_candidates The current count of track candidates. | ||
| * @return A list of all possible combinations of integers from {@code v1} and {@code v2}. | ||
| */ | ||
| private ArrayList<ArrayList<Integer>> cartesian_product(ArrayList<ArrayList<Integer>> v1, ArrayList<Integer> v2, MutableBoolean too_much_track_candidates, int number_of_track_candidates) { |
Collaborator
There was a problem hiding this comment.
probably simplifieable, maybe warrants optimization
baltzell
approved these changes
Mar 27, 2025
This was referenced Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, this option can be set up from the YAML file with the option Mode: