Skip to content

Fix N_hits issue & fill AHDC::track bank before KF#1137

Open
zyzhangjlab wants to merge 2 commits intoJeffersonLab:developmentfrom
zyzhangjlab:fillAHDCtrack
Open

Fix N_hits issue & fill AHDC::track bank before KF#1137
zyzhangjlab wants to merge 2 commits intoJeffersonLab:developmentfrom
zyzhangjlab:fillAHDCtrack

Conversation

@zyzhangjlab
Copy link
Contributor

  1. Fix the issue that there are events with number of hits < 6.
  2. fill chi2, sum_adc, path and dEdx in AHDC::track bank before Kalman Filter.

@ftouchte
Copy link
Collaborator

ftouchte commented Mar 5, 2026

I made some review. The idea is that, if a quantity can be calculated, we should not have a setter for it.

Example: sum_adc can be directly calculated, I guess the path is set. But dEdx uses both of these information.

We should make a choice. Whether we compute everything, whether we set everything.

As a consequence, some variables are left non used.

@baltzell
Copy link
Collaborator

baltzell commented Mar 6, 2026

@ftouchte et.al, if you think this should be merged, please approve it.

@baltzell baltzell enabled auto-merge (squash) March 7, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants