Better loader discovery#35
Merged
Merged
Conversation
Add abstract discover() classmethod to DataSource and concrete implementations on FieldLoaderBp, ParticleLoaderBp, ParticleLoaderH5. Not yet wired into the parser — Task 2 switches the registry over. Co-Authored-By: Claude <noreply@anthropic.com>
Switch LOADERS from prefix-keyed dict to list of loader classes plus a discover_all(data_dir) function that polls each loader's discover() classmethod. Loader decorators become bare @loader. parse.py's bespoke discover_particle_bp_loaders import + the FIXME hack go away — the particle BP loader is now uniform with the others. args.py exposes the constructed loader as args.loader. Test fixtures using the internal _get_parser API updated to match the new tuple return shape. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All loaders are responsible for discovering which prefixes they can open within a given directory. These declarations are passed to the argparse prefix
choices. This system replaces a hack introduced in #33 to register prt.bp prefixes specifically. Also, make Loader an intermediate ABC, below DataSource.