Move BinaryByteUnitTest into commonMain with preliminary iOS support.#30
Move BinaryByteUnitTest into commonMain with preliminary iOS support.#30vanniktech wants to merge 15 commits intoJakeWharton:masterfrom
Conversation
| @@ -9,7 +9,7 @@ package com.jakewharton.byteunits | |||
| * @see BinaryByteUnit | |||
| * @see BitUnit | |||
| */ | |||
| sealed interface ByteUnit { | |||
There was a problem hiding this comment.
I'll make it sealed again once everything is in commonMain. Currently, we can't mix between source sets.
There was a problem hiding this comment.
I can't. Actual implementations use that interface to implement it, which the Kotlin compiler does not allow if it's sealed.
| import platform.Foundation.NSNumberFormatter | ||
|
|
||
| /** | ||
| * A [BinaryByteUnit] represents power-of-two byte sizes at a given unit of granularity and |
There was a problem hiding this comment.
Do we want to duplicate the documentation or only have it at the commonMain level?
|
Do we need something so that the CI works? |
|
Downgrade to Gradle 7.5 or upgrade to Kotlin 1.8. |
|
Crazy week. I'll look soon. |
|
Okay renovate is on so a bunch of things got updated. Repo is on Kotlin 1.8 and Gradle 7.6 now so rebase and all should be good. |
|
@JakeWharton this is finally green now. |
|
@JakeWharton had some spare time and finished everything. The repo is now multiplatform with ios & jvm targets. Also adjusted all the tests. |
|
I'm on paternity leave in a week and will have more time to look. Kinda. Less work distraction, more like. |
|
No rush. I've published this myself: |
|
Resolved the conflicts. |
|
@JakeWharton friendly ping |
References #10
Is this how you'd want to do the enum dance? #10 (comment)
If so, I can continue with the others.