Pytest contributions#3
Closed
rwest wants to merge 16 commits into
Closed
Conversation
Author
|
I suggest that when we finally merge this effort to main we use the history that's in the |
Jackson wrote: Upon closer inspection, all of the setup_class methods in this file could be changed to setup_method, I just missed the others. None of the test_* methods change self (they just read it) so we don't need to execute the setup method over and over again
This is to reduce the overall impact of the pull request. Revert "DROP. changes permissions on some examples/arkane." This reverts commit 57e32774a6fa2ec7ea96a0efd29b021d5ecf0fa4.
This is to reduce the impact of the PR. This reverts commit dca4906cdbbcbb52f818687196ade5fd580c49f1.
Most of these were changed in
Author: Jackson Burns <jwburns@mit.edu>
Date: Sat Jul 22 15:35:13 2023 -0400
fix use of np.float and np.bool
but this one got missed or switched back somehow.
Revert "DROP this. Adds test/arkane/data/H2O2/H2O2.py (which is output)" This reverts commit 6d9ecdb.
If someone installs this, it should be excluded from their git.
The move is just putting it back where it was so the diff is less. Adding to the phony list because, well, it's a phony target.
It's not that I don't like black, per se, but the code churn of running it, in the middle of other things, merged with real changes, on a PR that's not even about arkane, is what I'm undoing.
This lot was rolled in to the commit "more hacks for pytest compat, remove deprecated methods"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits bring your pytest branch up to be the same as my
pytest3branch. I think we already discussed the changes (eg. these commits revert things that you agreed should be dropped) - but am contributing via a pull request so you can double check.I suggest we then switch the history to be the
pytest3version.