Marking class methods for c++ backend as virtual#9
Closed
budhe888 wants to merge 1 commit intoJPLOpenSource:mainfrom
Closed
Marking class methods for c++ backend as virtual#9budhe888 wants to merge 1 commit intoJPLOpenSource:mainfrom
budhe888 wants to merge 1 commit intoJPLOpenSource:mainfrom
Conversation
Author
|
This modification is not enough. In order for the parent class vtable to be emitted and the linking to work, we need the following additional mods:
The problem with this is that it I don't think it works without the -noImpl flag, so we need a little more plumbing to make this work. I will close PR for now, and make an issue ticket that references it. If I am able to submit a PR for this, then I will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to have the backend c++ option generate virtual methods in the class. That way an implementation can inherit and override the defaults.
This change simply adds that keyword to the cpp backend template.
I was able to run this with the state machine that I am currently working on and it produced the correct output. However is there a test setup you have in this repo that I should be running for this change?