Preserve TabLit single-line comments in AST#234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
reserve_comment/yue.to_ast) can include them, mirroring howBlockpreserves statement-or-comment sequences.Description
YueLineComment_tand includeYueLineComment_tinTableLit'svaluesvariant so table literal items can be comment nodes (src/yuescript/yue_ast.h).yue_line_commentas a table value item and useplain_spacefor those table literal positions to avoid swallowing comments (src/yuescript/yue_parser.cpp).YueLineComment_tnodes and emit them as comment lines without adding a trailing comma (so comment-only entries do not break generated Lua) (src/yuescript/yue_compiler.cpp).Testing
make -j2, which completed successfully.bin/release/yue -c -p /tmp/tab_comment.yue, and observed the output preserves the comment line inside the table (success).Codex Task