54 bug update comprehensive result overwrites failure description instead of accumulating it upd#60
Merged
Conversation
…scription_instead_of_accumulating_it_upd' of https://github.com/Inxton/TcOpen into 54-_BUG_UpdateComprehensiveResult_overwrites_failure_description_instead_of_accumulating_it_upd
…failure_description_instead_of_accumulating_it_upd
There was a problem hiding this comment.
Pull request overview
This PR updates how TcoComprehensiveResult failure descriptions and error codes are accumulated so they don’t get overwritten when an inspector (or inspection group) reports failure/inconclusive results.
Changes:
- Adjusted
TcoInspector.UpdateComprehensiveResultto accumulate descriptions into the in/out result instead of restoring and rewriting from the original snapshot. - Simplified
UpdateDescriptionsin bothTcoInspectorandTcoInspectionGroupto append onto the currentinoResultvalues (removing the extrainOriginalResultinput). - Updated
TcoInspectionGroup.UpdateComprehensiveResultlogic to combine the original overall result with the current run result when_doneis reached.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspector/TcoInspector.TcPOU | Stops resetting the overall result on fail/inconclusive and appends failure/error info into the current comprehensive result. |
| src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspectionGroup/TcoInspectionGroup.TcPOU | Refactors failure/error aggregation in group result computation, including concatenation with the original overall result at completion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+551
to
+552
| _refOverallResult.Failures :=concat( _originalOverallResult.Failures,_refOverallResult.Failures); | ||
| _refOverallResult.ErrorCodes :=concat( _originalOverallResult.ErrorCodes,_refOverallResult.ErrorCodes); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.