acumulation group inspection#58
Merged
Merged
Conversation
…failure_description_instead_of_accumulating_it_upd
There was a problem hiding this comment.
Pull request overview
This PR adjusts how TcoInspectionGroup.UpdateComprehensiveResult accumulates failure descriptions and error codes into the overall comprehensive result when an inspection fails.
Changes:
- Switches concatenation inputs from
_refOverallResult.*to_originalOverallResult.*when appending_currentRunResultfailure/error details. - Keeps the overall result reset to
_originalOverallResultbefore marking the result asFailedand aggregating details.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
545
to
+546
| IF _refOverallResult.Failures<>'' THEN | ||
| _refOverallResult.Failures := concat(concat(_refOverallResult.Failures,';'), _currentRunResult.Failures); | ||
| _refOverallResult.Failures := concat(concat(_originalOverallResult.Failures,';'), _currentRunResult.Failures); |
Comment on lines
551
to
+552
| IF _refOverallResult.ErrorCodes<>'' THEN | ||
| _refOverallResult.ErrorCodes := concat(concat(_refOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes); | ||
| _refOverallResult.ErrorCodes := concat(concat(_originalOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.