Merged
Conversation
7fe2be7 to
dea2e60
Compare
Collaborator
Author
|
HUD stuff to show turtle fuel require Mixins and a read lot of minecraft asm, I don't think if I can done that recently. If I got the HUD bar working, I'll make another PR |
Collaborator
Author
|
As well as the saddle turtle's model need better saddle drawing, rather than just show the saddle on the side ... |
Collaborator
Author
|
But anyways, forge already did that mixin for you, so the HUD is done 💦 |
also make the minimum action cooldown to 100ms
…ncedPeripherals into tamed-turtle-patch
Signed-off-by: Kevin Z <zyxkad@gmail.com>
…ncedPeripherals into tamed-turtle-patch
Collaborator
Author
|
@SirEndii This is ready for review again |
Member
|
gonna review that tomorrow |
SirEndii
reviewed
Jun 2, 2024
src/main/java/de/srendi/advancedperipherals/common/util/LuaConverter.java
Show resolved
Hide resolved
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
captureperipheral method, andreleasefor dismountgetRiderto get the information of the captured entityE) can open the turtle's GUIDoes this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
Other information: