fix(Pull-SDLC): remove unsolicited SSH-on-443 drift nudge#170
Merged
Conversation
A per-repo instructions-sync script must not lobby users to mutate machine-wide configuration on every successful run. The drift nudge added in #164 printed a yellow "Recommendation: GitHub SSH-on-443 setup is incomplete..." line at the end of every sync on a Windows workstation that had not opted into the (opinionated, invasive) SSH-on-443 setup -- including url.insteadOf rewrites that silently force *all* GitHub traffic through ssh.github.com:443, overriding gh, per-repo remotes, and any other tooling. Removed: - Post-sync drift-check block in Pull-SDLC.ai.ps1 (was printing the nudge) - Test-GitHubSshDrift function (only consumer was the nudge block) - Write-GitHubSshNudge function (only consumer was the nudge block) - Pester tests covering the removed helpers (5 tests) Added: - Regression test asserting neither helper is referenced from the script, so the unsolicited nudge cannot reappear via a partial revert. Kept (out of scope for this fix): - -SetupGitHubSsh switch and Invoke-SetupGitHubSsh function remain as an opt-in path for users who explicitly want the setup. A broader redesign (renaming to -SetupGit and refocusing on repo- level git configuration like .gitignore/.gitattributes instead of SSH/protocol) is tracked separately. Closes #169 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 31, 2026
redesign: replace -SetupGitHubSsh with -SetupGit (repo-level git scaffolding, not SSH/protocol)
#171
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unsolicited yellow
Recommendation: GitHub SSH-on-443 setup is incomplete...line that printed at the end of every successfulPull-SDLC.ai.ps1run on Windows.A per-repo instructions-sync script must not lobby users to mutate machine-wide config (
~/.ssh,git config --global,gh config) on every invocation. The setup that the nudge promoted is also opinionated: it writesinsteadOfrewrites that silently force all GitHub traffic throughssh.github.com:443, overridinggh, per-repo remotes, and other tooling.Changes
Pull-SDLC.ai.ps1.Test-GitHubSshDriftandWrite-GitHubSshNudge(only callers were the deleted block).Out of scope
-SetupGitHubSshswitch andInvoke-SetupGitHubSshremain as an opt-in path. A broader redesign (rename to-SetupGit; refocus on repo-level git configuration like.gitignore/.gitattributesinstead of SSH/protocol) is tracked in a follow-up issue.Verification
\\\powershell Invoke-Pester -Path .\Pull-SDLC.ai.Tests.ps1 -FullNameFilter '*post-sync output*' -Output Detailed\\The new regression test fails when the deletion is reverted (assertion failure on
Should -Not -Match 'Write-GitHubSshNudge').Closes #169