remove einsum_call kwargs from dpnp.einsum_path signature
#2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Apr 14, 2025
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2421/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_4 ran successfully. |
antonwolfy
reviewed
Apr 14, 2025
antonwolfy
approved these changes
Apr 14, 2025
Contributor
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vtavana for handling that. Just a small comment from me, but in overall LGTM!
Co-authored-by: Anton <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Apr 14, 2025
`einsum_call` is a [hidden kwarg](https://github.com/numpy/numpy/blob/main/numpy/_core/einsumfunc.pyi#L174). In NumPy, it has been used internally inside `einsum` but it is not needed in dpnp so removing it from the signature. --------- Co-authored-by: Anton <[email protected]> 316240c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
einsum_callis a hidden kwarg. In NumPy, it has been used internally insideeinsumbut it is not needed in dpnp so removing it from the signature.