Rework implementation of dpnp.unwrap function
#1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
reviewed
Jul 30, 2024
Contributor
Author
|
The timing on PVC with the following example: a = numpy.random.rand(10**6).astype(dtype) * 1000
_ = numpy.unwrap(a, period=355)
ia = dpnp.array(a)
b = dpnp.unwrap(ia, period=355); b.sycl_queue.wait()in the table below
|
vlad-perevezentsev
approved these changes
Aug 2, 2024
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Looks good!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Aug 2, 2024
* Align doc page of Mathematical functions with numpy * Implement dpnp.unwrap() function * Enable muted tests * Add more tests * Resolve pre-commit issue * Apply suggestions from code review Co-authored-by: vtavana <[email protected]> * Replace dpnp.copyto with dpnp.where --------- Co-authored-by: vtavana <[email protected]> d2c623b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to rework implementation of
dpnp.unwrapfunction which are quite limited now.Added support for all keywords provided by
numpy.unwrap.The page with a table of mathematical functions is aligned with actual numpy content.
The all affected tests are updated to cover different use cases.