Skip to content

Rework implementation of dpnp.fmax and dpnp.fmin functions #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonwolfy merged 7 commits into from
Jul 4, 2024
Merged

Rework implementation of dpnp.fmax and dpnp.fmin functions #1905

antonwolfy merged 7 commits into from
Jul 4, 2024

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 2, 2024 •
edited
Loading

The PR proposes to rework implementation of dpnp.fmax and dpnp.fmin functions which are quite limited now.

There is new VM functions are added to use fmax and fmin from OneMKL library where it's possible.
Also the PR adds new binary universal functions _fmax and _fmin to _ufunc_impl pybind11 extension which leverages on dpctl f/w.

The all affected tests are updated to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Base automatically changed from adopt-to-asynchronous-dpctl-execution to master July 2, 2024 14:50
@antonwolfy antonwolfy marked this pull request as ready for review July 2, 2024 16:13
npolina4
npolina4 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 05e1bb6 into master Jul 4, 2024
@antonwolfy antonwolfy deleted the add-fmax-fmin-impl branch July 4, 2024 16:14
github-actions bot added a commit that referenced this pull request Jul 4, 2024
@github-actions
Rework implementation of dpnp.fmax and dpnp.fmin functions (#1905)
7b76f77 
* Implement dpnp.fmax and dpnp.fmin functions

* Updated existing tests and added new ones

* Removed unused code from cython backend

* Removed a reference to original descriptor 05e1bb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

1 more reviewer

@npolina4 npolina4 npolina4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @npolina4