Support out parameter for dpnp.all/any()
#1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
reviewed
Jun 25, 2024
vtavana
approved these changes
Jun 26, 2024
Contributor
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @vlad-perevezentsev!
antonwolfy
approved these changes
Jun 26, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2024
* Update dpnp.all/any with support out param * Update cupy tests * Add TestAllAny * Update dpnp tests * Apply comments --------- Co-authored-by: Anton <[email protected]> 323ce50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding support
outparameter fordpnp.all()anddpnp.any()functions usingdpnp.get_result_array()as a W/A untildpctladds supportoutparameter.This also updates docstings and adds new tests to cover the new implementation