Skip to content

Conversation

@npolina4
Copy link
Contributor

@npolina4 npolina4 commented Jun 18, 2024

Cleaned up legacy element-wise implementation from the backend for speed up build and improve code coverage.

Changes was tested with numda-dpex component.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 , it's very helpful change.

@antonwolfy antonwolfy merged commit a265663 into master Jun 28, 2024
@antonwolfy antonwolfy deleted the cleanup_elementwise branch June 28, 2024 11:44
github-actions bot added a commit that referenced this pull request Jun 28, 2024
* Clean up legacy element-wise implementation from the backend

* return legacy copy implementation for partition function

* Apply comments

* Fix pre-commit

* Fix pre-commit

* Clean-up MACRO_2ARG_2TYPES_LOGIC_OP. Clean-up /backend/include

---------

Co-authored-by: Anton <[email protected]>
Co-authored-by: Anton Volkov <[email protected]> a265663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants