Skip to content

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented May 9, 2024

Check #1844 for a correction to this PR.

In this PR, dpnp.kron and dpnp.dot are being called for special cases of dpnp.matmul.
In addition, dpnp_matmul is re-organized to better serve for future code development..

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this May 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

reorganizing for easier future code development
calling dpnp.kron and dpnp.dot for special cases in dpnp.matmul
@vtavana vtavana force-pushed the update-dpnp_matmul branch from c8056e0 to d4ff047 Compare May 9, 2024 15:43
@vtavana vtavana changed the title reorganize the structure of dpnp_matmul function call dpnp.kron and dpnp.dot for special cases in dpnp_matmul May 9, 2024
@vtavana vtavana marked this pull request as ready for review May 9, 2024 16:42
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit e1dcc45 into master May 14, 2024
@vtavana vtavana deleted the update-dpnp_matmul branch May 14, 2024 19:09
github-actions bot added a commit that referenced this pull request May 14, 2024
…1815)

* reorganize the structure of dpnp_matmul function

reorganizing for easier future code development
calling dpnp.kron and dpnp.dot for special cases in dpnp.matmul

* address comments

* improve coverage

* fix pre-commit

---------

Co-authored-by: Anton <[email protected]> e1dcc45
@vtavana vtavana mentioned this pull request May 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants