Update indexing functions #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
May 10, 2024
Contributor
Author
|
Test tests/third_party/cupy/indexing_tests/test_generate.py::TestTriuIndicesFrom::test_triu_indices_from_1 fixed by IntelPython/dpctl#1681 |
Contributor
Do you know when the fix will be available in internal channel? |
antonwolfy
reviewed
May 20, 2024
antonwolfy
reviewed
May 21, 2024
antonwolfy
reviewed
May 21, 2024
github-actions bot
added a commit
that referenced
this pull request
May 22, 2024
* Update indexing functions * Add CFD and tests * Improve code coverage * address comments * address comments * Added commit --------- Co-authored-by: Anton <[email protected]> b4578dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs and implementation of indexing functions:
dpnp.diag_indices,
dpnp.diag_indices_from,
dpnp.fill_diagonal,
dpnp.tril_indices,
dpnp.tril_indices_from,
dpnp.triu_indices,
dpnp.triu_indices_from.
Implemented dpnp.mask_indices function.