Documented wrapping behavior of out of bound values of sorter #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensor.searchsorter apply sorter array, if present, to first input array using tensor.take with default mode="wrap", which replaces out of bound indices with in-bound ones using modular reduction.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_148 ran successfully. |
ndgrigorian
previously approved these changes
Mar 20, 2024
antonwolfy
reviewed
Mar 20, 2024
7e11d06 to
dd36894
Compare
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_149 ran successfully. |
antonwolfy
approved these changes
Mar 21, 2024
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @oleksandr-pavlyk. The behavior is crystal clean now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensor.searchsorterappliessorterarray, if present, to first input array usingtensor.takewith defaultmode="wrap", which replaces out of bound indices with in-bound ones using modular reduction.This closes gh-1599