Skip to content

Custom implementation of isfinite #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oleksandr-pavlyk wants to merge 3 commits into from
Closed

Custom implementation of isfinite #1383

oleksandr-pavlyk wants to merge 3 commits into from

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Aug 31, 2023

This PR should address issues test failures from gh-1378

It works around very annoying SYCLOS bug introduced with pull down of clang 18.0

It adds a custom implementation of math_utils::isfinite to work around this failure.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1383/index.html

@coveralls
Copy link
Collaborator

coveralls commented Aug 31, 2023

Coverage Status

coverage: 85.635%. remained the same when pulling dca0650 on custom-is-finite into 9f98baf on master.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_37 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_38 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review September 1, 2023 03:23
@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented Sep 1, 2023

@ndgrigorian This PR has fixed SYCL-OS workflow.

@ndgrigorian
Copy link
Collaborator

ndgrigorian commented Sep 1, 2023

This PR should address issues test failures from gh-1378

Nit but I think you meant gh-1375 here.

ndgrigorian
ndgrigorian reviewed Sep 1, 2023
View reviewed changes
dpctl/tensor/libtensor/include/kernels/elementwise_functions/isnan.hpp

namespace py = pybind11;
namespace td_ns = dpctl::tensor::type_dispatch;
namespace mu_ns = dpctl::tensor::math_utils;
Copy link
Collaborator

@ndgrigorian ndgrigorian Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In isnan.hpp, math_utils is imported and the namespace is set, but never used to call mu_ns::isnan

Copy link
Contributor Author

@oleksandr-pavlyk oleksandr-pavlyk Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the fix. Thanks for spotting that out @ndgrigorian . I was after std::isnan instances and missed sycl::isnan.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_39 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented Sep 6, 2023

Since the issue has been fixed in SYCLOS, perhaps this PR can wait.

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Sep 6, 2023
Merged
6 tasks
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_54 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_54 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as draft September 7, 2023 09:49
@oleksandr-pavlyk
Introduce custom math_utils::isfinite
0481253 
This works-around a bug in std::isinfite recently introduced in SYCLOS
where std::isfinite(-0.0) returns false for floating point types, including
sycl::half, float, double.
@oleksandr-pavlyk
Implemented math_utils::isnan, math_utils::isinf
e657065
@oleksandr-pavlyk
Use mu_ns::isnan rather than sycl::isnan for uniformity.
4ff0543
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_4 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented May 21, 2024

Closing as no longer relevant

@oleksandr-pavlyk oleksandr-pavlyk deleted the custom-is-finite branch December 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian left review comments

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy will be requested when the pull request is marked ready for review antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @ndgrigorian