Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Moved the assertion about comparison with generic types before other assertions in test_flags test

This change is made in reference to Coverity scan issue, which is a false positive, but the test can be improved anyway.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Moved the assertion about comparison with generic types before
other assertions.

This change is made in reference to Coverity scan issue.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.635% (+0.001%) from 85.634% when pulling 55bb70f on tweak-test-flags into cf4660d on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully.
Passed: 915
Failed: 85
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1993eae into master Aug 27, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the tweak-test-flags branch August 27, 2023 16:49
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants