Skip to content

Fix path pattern for rephased VCF files#130

Merged
ljwharbers merged 3 commits into
IntGenomicsLab:devfrom
Tim-Yu:dev
Mar 9, 2026
Merged

Fix path pattern for rephased VCF files#130
ljwharbers merged 3 commits into
IntGenomicsLab:devfrom
Tim-Yu:dev

Conversation

@Tim-Yu
Copy link
Copy Markdown
Contributor

@Tim-Yu Tim-Yu commented Mar 6, 2026

Missing output file(s) phasing_output/*.rephased.vcf.gz expected by process `INTGENOMICSLAB_LRSOMATIC:LRSOMATIC:WAKHAN

The WAKHAN is generating /rephased.vcf.gz and /rephased.vcf.gz.csi
Just incase, I preserved the * for other potential matching
#128

PR checklist

  • This comment contains a description of changes (with reason).

Missing output file(s) `phasing_output/*.rephased.vcf.gz` expected by process `INTGENOMICSLAB_LRSOMATIC:LRSOMATIC:WAKHAN
@ljwharbers
Copy link
Copy Markdown
Collaborator

ljwharbers commented Mar 6, 2026

Looks good, feel free to merge after the run nf-test completes. You can ignore the template version fail for now.

PS: We will update wakhan to 0.4.2 next week, so this should resolve some wakhan related issues hopefully as well. If you want, you can include the version bump already here, but we have then not yet tested this.

Comment thread modules/local/wakhan/main.nf Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To update wakhan:

    container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
        'https://depot.galaxyproject.org/singularity/wakhan:0.4.2--pyhdfd78af_0':
        'biocontainers/wakhan:0.4.2--pyhdfd78af_0' }"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the environment.yml file to 0.4.2.

@ljwharbers ljwharbers merged commit 16291c4 into IntGenomicsLab:dev Mar 9, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants