Skip to content
This repository was archived by the owner on Jun 6, 2026. It is now read-only.

BUG: Add compile definitions for wrapping to work#6

Merged
phcerdan merged 1 commit into
InsightSoftwareConsortium:masterfrom
phcerdan:add_compile_definition
Apr 9, 2019
Merged

BUG: Add compile definitions for wrapping to work#6
phcerdan merged 1 commit into
InsightSoftwareConsortium:masterfrom
phcerdan:add_compile_definition

Conversation

@phcerdan

@phcerdan phcerdan commented Apr 9, 2019

Copy link
Copy Markdown
Collaborator

Requires ITK with patch:
InsightSoftwareConsortium/ITK#707

@phcerdan phcerdan requested a review from thewtex April 9, 2019 17:59
@phcerdan phcerdan force-pushed the add_compile_definition branch from 445e2bb to 57af53b Compare April 9, 2019 20:32
@phcerdan

phcerdan commented Apr 9, 2019

Copy link
Copy Markdown
Collaborator Author

Cool, #7 makes Build and Test macOS green.

The failure in python packages is expected until ITK5.0 rc2 where the patch to the castxml command would be in place. Wrapping locally works in Linux and Mac, not tested on Windows yet.

@phcerdan phcerdan merged commit cb164f9 into InsightSoftwareConsortium:master Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant