COMP: Mangle hdf5 static symbols#3478
Merged
thewtex merged 1 commit intoJul 2, 2022
Merged
Conversation
This commit expands the list of hdf5 symbols to include the one associated the BSS data section. The list was put together by using nm, c++filt, bash tooling and manual inspection of the source files.
dzenanz
approved these changes
Jul 2, 2022
Contributor
|
When someone in the future updates HDF5 in ITK (which I sometimes do), how will they reproduce what you've done here? You didn't seem to add any doc/instructions. |
9 tasks
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…mangle-static-symbols COMP: Mangle hdf5 static symbols
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 12, 2026
…mangle-static-symbols COMP: Mangle hdf5 static symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the list of hdf5 symbols to include the one associated
the BSS data section. The list was put together by using nm, c++filt, bash
tooling and manual inspection of the source files.
This PR introduces ABI changes related to symbols not explicitly made available to client projects.
Context
This pull request was created in the context of the integration of ITK Python within the Slicer python interpreter. It allows to instantiate the HDF5 reader (
itk.HDF5ImageIO.New()) without leading to seg fault.Caveats
Note that instantiating the reader worked because the symbols in the library imported through wheel were effectively different from the one in the ITK libraries built by Slicer.
Once this is integrated and the ITK wheel rebuilt, the symbol clash is likely to happen again.
Possible path forward
Allowing client project to customize the mangling by for example specifying
slicer_for third-party like HDF5 would help avoid issue.PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.