Improve Git repository authentication handling#356
Open
dylangovender wants to merge 3 commits intoInseeFrLab:mainfrom
Open
Improve Git repository authentication handling#356dylangovender wants to merge 3 commits intoInseeFrLab:mainfrom
dylangovender wants to merge 3 commits intoInseeFrLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run Onyxia in an environment where repositories are hosted across GitHub, GitLab, and Bitbucket. While testing the init script, we found that cloning from Bitbucket instances did not work correctly because the authentication pattern differs from GitHub and GitLab.
This change adds a Bitbucket-specific authentication pattern (username:token@host) so that repositories hosted on Bitbucket can be cloned successfully.
It also changes the sed delimiter from / to | when rewriting the repository URL. Using / caused issues when tokens contained characters that conflicted with the delimiter.
These changes were tested in our environment and cloning now works correctly for GitHub, GitLab, and Bitbucket repositories.