feat: align tensordot with PyTorch Python API#812
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
voltjia
force-pushed
the
feat/align-tensordot-python-api
branch
from
July 24, 2026 08:02
5056ac1 to
94bda51
Compare
voltjia
force-pushed
the
feat/align-tensordot-python-api
branch
from
July 24, 2026 08:27
94bda51 to
9f047f1
Compare
voltjia
force-pushed
the
feat/align-tensordot-python-api
branch
from
July 24, 2026 11:07
9f047f1 to
2360ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tensordot(a, b, dims, out)forms: integerdimsand a pair of dimension lists.dims_self, dims_otherinterface as a[[deprecated]]compatibility overload.Motivation
The previous interface only exposed the lower-level pair of dimension lists. PyTorch exposes one
dimsargument that accepts either an integer or a pair of lists. The earlier revision also added a no-dimsconvenience overload; this revision removes it to keep the overload set minimal.No standalone issue is associated with this alignment follow-up.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. Integer dimensions are expanded during operator construction; the existing ATen execution path is unchanged.
Notes for Reviewers
API alignment
tensordot(a, b, dims, out)wheredimsisint64_tdimsform; explicitoutremains last perCONTRIBUTING.md.tensordot(a, b, dims, out)wheredimsis two dimension listsdimsform.torch.tensordot(a, b, dims=2, out=None)tensordot(input, other, dims_self, dims_other, out)dims=2explicitly when they want the PyTorch default.