feat: align argsort with PyTorch parameter order#809
Merged
Conversation
voltjia
force-pushed
the
feat/align-argsort-python-api
branch
from
July 24, 2026 08:02
5e16a66 to
6e250e4
Compare
voltjia
force-pushed
the
feat/align-argsort-python-api
branch
from
July 24, 2026 08:27
6e250e4 to
1585c2c
Compare
voltjia
marked this pull request as ready for review
July 24, 2026 08:38
argsort with PyTorch parameter order
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argsort(input, dim, descending, stable, out)interface and trailing-default overloads.input, stable, dim, descending, outinterface as an explicitly deprecated overload and cover both paths in the existing operator test module.Motivation
The current public parameter order follows neither the PyTorch Python API nor its positional semantics. This change makes the primary InfiniOps interface match
torch.argsort, while preserving a migration path for existing callers.No standalone issue is associated with this alignment follow-up.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Additional validation
Benchmark / Performance Impact
N/A. This changes API routing only; the underlying ATen implementation is unchanged.
Notes for Reviewers
API alignment
argsort(input, dim=-1, descending=False, stable=False, out)outremains last perCONTRIBUTING.md.torch.argsort(input, dim=-1, descending=False, stable=False, *, out=None)argsort(input, stable, dim, descending, out)constructor and call operator remain available with[[deprecated]]migration diagnostics.