Make Rewrite layer pluggable#121
Conversation
Added Javadoc
…into GRILL-618
…into GRILL-618
…into GRILL-618
…into GRILL-618
…into GRILL-618
…into GRILL-618
…into GRILL-618
|
Fixed all Test Case failures in grill-driver-cube and added UTs. Test cases failing due to Rewriter not getting inited in QueryExecutionService. Looking into it |
|
Fixed grill server UT failures. Grill-cli - one test is failing still . Looking into it Failed tests: Tests run: 12, Failures: 1, Errors: 0, Skipped: 0 |
|
The above Issues were due to JAVA_HOME not being set. All tests are passing in grill-cli as well Results : Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 |
…into GRILL-618
|
Some basic observations -
|
There was a problem hiding this comment.
if this is a constant pls make is private static final and all caps
|
The header license template has changed, please use the latest license template. |
There was a problem hiding this comment.
Does this class have to be a singleton? I think this can be contained in LensServices instance.
|
lens code should be agnostic to DSL and specific command types. lets relook this. |
Initial review draft. Adding Tests for new code are still pending. Am working on them Existing tests are passing.