feat: httpc_params_loader (httpc default timeout refactor) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c17437 to
18066fe
Compare
jschlyter
previously approved these changes
Oct 11, 2021
18066fe to
703b0d8
Compare
jschlyter
previously approved these changes
Oct 11, 2021
a60c1d4 to
c0e436c
Compare
Member
Author
|
fixed all the warnings that raises up during unit tests execution something went wrong but only in gh actions CI not in my workstation, I'm on it. |
c0e436c to
29fca4a
Compare
Member
Author
|
fixed, all done @rohe @jschlyter |
rohe
approved these changes
Oct 11, 2021
jschlyter
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor of the previous commit
#94 (review)