first cut at proper read/write locking for KeyBundle #83
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #83 +/- ##
===========================================
+ Coverage 77.50% 77.60% +0.10%
===========================================
Files 41 41
Lines 4276 4296 +20
Branches 832 833 +1
===========================================
+ Hits 3314 3334 +20
Misses 700 700
Partials 262 262
Continue to review full report at Codecov.
|
janste63
left a comment
There was a problem hiding this comment.
Missed writer method: do_keys
Missed reader methods: contains, iter, len, copy
Maybe iter should work on a copy to avoid errors.
src/cryptojwt/key_bundle.py
Outdated
| _typs = [typ.lower(), typ.upper()] | ||
| _keys = [k for k in self._keys if k.kty in _typs] | ||
| else: | ||
| _keys = self._keys |
src/cryptojwt/key_bundle.py
Outdated
| if update: | ||
| self._uptodate() | ||
| with self._lock_reader: | ||
| return self._keys |
There was a problem hiding this comment.
Need a shallow copy here. Optimization, save the copy and remove copy every time keys_writer() is called.
Well since the name doesn't start with "_" it suggest that it can be called from the outside. Suggestion, make it private. The method load() calls do_keys() with no locking. |
- create public version of do_keys (with write lock)
KeyBundle is tricky as it updates its own keys from multiple places in the code. This PR uses readwriterlock to put a read lock around key reads and a write lock updates.
The write lock is implemented using a decorator, whereas the read lock implemented using explicit
with. Most key access has been moved tokeys()in order to simplify the code.There may be dragons - please review carefully. Extra set of eyes from @janste63 would be most useful.