Fix alg matching in pick_key #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you provide a test mimicking your use case ? |
Contributor
Author
|
I added a test case at end of test_5_jwt.py. The scenario is that I download a JWKS with public keys from an OIDC sever that has "alg" set. |
Contributor
Author
|
Ping, is it possible to get this merged? |
Contributor
Author
|
Thanks a lot! Could you also publish the release? |
Contributor
|
Will do later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this problem when trying to verify JWT signatures with key entries that specified "alg". The simple solution was to make "alg" wildcard match like the "kid".
Another improvement could also be to supply the "alg" when picking keys for JWT signature verification. But I'vent examined the code enough to see if it has some other implications.