chore: removed RSA1_5 as default enc alg #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 77.26% 77.44% +0.17%
==========================================
Files 41 42 +1
Lines 4324 4362 +38
Branches 836 842 +6
==========================================
+ Hits 3341 3378 +37
Misses 718 718
- Partials 265 266 +1
Continue to review full report at Codecov.
|
jschlyter
previously approved these changes
Jun 21, 2022
Collaborator
jschlyter
left a comment
There was a problem hiding this comment.
Perhaps the commit should say what we replace it with?
Would it make sense to also move from CBC to GCM?
peppelinux
commented
Jun 21, 2022
Contributor
|
Not that I know of. |
rohe
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.