[Fix] 0039485 UI: Escape HTML tag names in Standard Page accessibilit…#11010
[Fix] 0039485 UI: Escape HTML tag names in Standard Page accessibilit…#11010fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
Conversation
Annett7811
left a comment
There was a problem hiding this comment.
Hello!
From an accessibility perspective, this looks good. Thank you very much for your work.
Best regards,
Annett
|
Hello together, Kind regards, |
thibsy
left a comment
There was a problem hiding this comment.
Hi @fhelfer,
Thx a lot for your contribution to the UI framework!
I am not convinced that this is the appropriate solution here. This will be immediately forgotten and the next UI component description might feature characters that need escaping again.
Please implement the following changes:
- Escaping location: please either try to find an appropriate location inside the
ILIAS\UI\Implementation\Crawlernamespace or theilKSDocumentation*GUI classes, to properly escape future characters as well.
Kind regards,
@thibsy (as UI coordinator)
Error Bad character “ ” after “<”. Probable cause: Unescaped “<”. Try escaping it as “<”.
https://mantis.ilias.de/view.php?id=39485
Replace < main >, < header >, < footer > with <main>, <header>,
<footer> in the docblock so the Kitchen Sink documentation renders
valid HTML (no "Bad character after <" validator errors).
Problem
Lösung
standard()-Methode in Layout/Page/Factory.php die Tag-Namen als Entities schreiben:<main>,<header>,<footer>.<main>etc. gerendert, ohne ungültiges Markup.build-artifacts), damit die Doku aktuell ist.