Skip to content

Comments

[Fix] 0039485 UI: Escape HTML tag names in Standard Page accessibilit…#11010

Open
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/39485
Open

[Fix] 0039485 UI: Escape HTML tag names in Standard Page accessibilit…#11010
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/39485

Conversation

@fhelfer
Copy link
Contributor

@fhelfer fhelfer commented Jan 30, 2026

Error Bad character “ ” after “<”. Probable cause: Unescaped “<”. Try escaping it as “<”.
https://mantis.ilias.de/view.php?id=39485

Replace < main >, < header >, < footer > with <main>, <header>,
<footer> in the docblock so the Kitchen Sink documentation renders
valid HTML (no "Bad character after <" validator errors).

Problem

  • In der System-Style-Dokumentation (Standard Page, Accessibility) führten die Docblock-Texte "the HTML tag < main >", "< header >", "< footer >" zu Validator-Fehlern: "Bad character ' ' after '<'".

Lösung

  • Im Docblock der standard()-Methode in Layout/Page/Factory.php die Tag-Namen als Entities schreiben: &lt;main&gt;, &lt;header&gt;, &lt;footer&gt;.
  • Beim Anzeigen der Doku wird daraus korrekt <main> etc. gerendert, ohne ungültiges Markup.
  • Nach dem Merge: Artifact ggf. neu bauen (build-artifacts), damit die Doku aktuell ist.

@fhelfer fhelfer added kitchen sink improvement php Pull requests that update Php code labels Jan 30, 2026
@Annett7811 Annett7811 added the accessibility Pull requests that propose A11Y changes. label Feb 6, 2026
@Annett7811 Annett7811 self-requested a review February 13, 2026 10:59
Copy link

@Annett7811 Annett7811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

From an accessibility perspective, this looks good. Thank you very much for your work.

Best regards,

Annett

@oliversamoila
Copy link
Contributor

Hello together,
Thank you very much for your contribution, @fhelfer. Thanks you for your review, @Annett7811. I agree and don't see these issues anymore.
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)

Kind regards,
@oliversamoila (as UI coordinator)

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fhelfer,

Thx a lot for your contribution to the UI framework!

I am not convinced that this is the appropriate solution here. This will be immediately forgotten and the next UI component description might feature characters that need escaping again.

Please implement the following changes:

  • Escaping location: please either try to find an appropriate location inside the ILIAS\UI\Implementation\Crawler namespace or the ilKSDocumentation* GUI classes, to properly escape future characters as well.

Kind regards,
@thibsy (as UI coordinator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Pull requests that propose A11Y changes. improvement kitchen sink php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants