Skip to content

customize header, footer and homepage#1

Merged
milanmajchrak merged 5 commits intoTUL/dtq-devfrom
TUL-188/customize-header-footer-and-homepage
Jun 1, 2023
Merged

customize header, footer and homepage#1
milanmajchrak merged 5 commits intoTUL/dtq-devfrom
TUL-188/customize-header-footer-and-homepage

Conversation

@HuynhKhoa1601
Copy link
Copy Markdown
Owner

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

dataquest-dev#188

@milanmajchrak
Copy link
Copy Markdown
Collaborator

I think :hover background color in the menu should be the same like in the https://www.tul.cz/ .
TUL:
image
Your:
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

milanmajchrak commented May 29, 2023

Log in: the buttons doesn't change the color on :hover event. I think it should get a little bit darker like in the Vanilla.
image

I think you can copy :hover style from the tul.cz buttons:
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

dspace.tul.cz has another info in the footer than Vanilla DSpace. Please update the footer and add there Contact Us option with redirection to /contact.

align-items: baseline;
background-color: var(--lt-tul-purple);
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add here :hover colors

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

//
// Style anchor elements.
--bs-link-color: #{$link-color};
--bs-link-color: white;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better solution could be updating link-color what do you think?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@@ -1,15 +1,19 @@
@font-face {
font-family: 'TUL Mono';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tul.cz has in the navbar 0.85rem 'TUL Mono', sans-serif; is it the same?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it

Comment thread src/styles/_bootstrap_variables.scss Outdated
danger: $red,
light: $gray-100,
dark: $dark
"primary": $blue,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you wrap it in the quotation marks? Are we sure it won't break other components which are using this $theme-colors?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, my bad. I'll revert it

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to make it consistent

@milanmajchrak
Copy link
Copy Markdown
Collaborator

image
On :hover the background color of TUL icon is not changed like in the tul.cz
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

image
Search button and Language Switch button background colors are not changed on the :hover event like in the rest of the menu.
It should be changed like in the e.g., Statistics menu button
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

You can see the border of the button on the :hover event:
image

it should be smooth. Do you see it?

@milanmajchrak
Copy link
Copy Markdown
Collaborator

After :hover the hover-border of the button still could be seen:
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

milanmajchrak commented May 30, 2023

:hover colors are not the same in the menu options:
image
image

@milanmajchrak
Copy link
Copy Markdown
Collaborator

@HuynhKhoa1601 I think it looks good :) Thanks.
I see one more fix and I believe for now the home page will be done.

My last suggestion is:
the dropdown menu is rolled down before the mouse cursor is changed. If you go through All of DSpace menu option slowly you should see this behaviour.
image

@milanmajchrak milanmajchrak self-requested a review June 1, 2023 13:47
@milanmajchrak milanmajchrak merged commit a4667c5 into TUL/dtq-dev Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants