Skip to content

add keys function to dictionary #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boulter merged 1 commit into from
Oct 26, 2022
Merged

add keys function to dictionary #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/hubspot/jinjava/objects/collections/PyMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ public Set<java.util.Map.Entry<String, Object>> items() {
return entrySet();
}

public Set<String> keys() {
return keySet();
}

public void update(Map<? extends String, ? extends Object> m) {
if (m == this) {
throw new IllegalArgumentException("Can't update map object with itself");
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/com/hubspot/jinjava/el/ext/AstDictTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ public void itDoesItemsMethodCall() {
.isInstanceOf(Set.class);
}

@Test
public void itDoesKeysMethodCall() {
interpreter.getContext().put("foo", ImmutableMap.of(TestEnum.BAR, "test"));
assertThat(interpreter.resolveELExpression("foo.keys()", -1)).isInstanceOf(Set.class);
}

@Test
public void itHandlesEmptyMaps() {
interpreter.getContext().put("foo", ImmutableMap.of());
Expand Down