Fix bug with whitespace controls not applying properly #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
approved these changes
Feb 17, 2021
Contributor
jasmith-hs
left a comment
There was a problem hiding this comment.
This seems like a good solution. We essentially want the adjacent text tokens to be treated as the same token when handling whitespace, so merging them makes sense.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace controls operate on the assumption that textnodes cannot be adjacent. You can break up text nodes with a comment node
\n {# comment #} \n. This should not affect the whitespace control but it does under the current code. In order to solve for this I merged adjacent text nodes. I did try a few other approaches over a couple of hours to try to get the same effect but could not solve for the case where there are more than 2 text nodes stacked next to each other.