Fix NPE for loop tuple vars of null. #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
approved these changes
Mar 4, 2024
Contributor
jasmith-hs
left a comment
There was a problem hiding this comment.
This change looks good, but my concern about NullValue from #1147 (comment) and #1140 (comment) still exists
Comment on lines
+219
to
+226
| if ( | ||
| interpreter.getContext().get(loopVar) != null && | ||
| interpreter.getConfig().getLegacyOverrides().isKeepNullableLoopValues() | ||
| ) { | ||
| interpreter.getContext().put(loopVar, NullValue.INSTANCE); | ||
| } else { | ||
| interpreter.getContext().put(loopVar, null); | ||
| } |
Contributor
There was a problem hiding this comment.
This and L#208-214 can be extracted to a single method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the a loop value is null, we should not try to get the
.getClass()of it. It throws a NPE. We fixed this for single var loops, did not expect this also happens for tuples.A bad jinjava tag can trigger it: