Feature/sync upstream #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/1.2.41
The error messages are subject to change, but the codes are not, so assert the code instead. Signed-off-by: Lewis Marshall <[email protected]>
tests: Assert connection error code rather than message
ci: enable workflow_dispatch
…itcodeai comments
…nnelOption Fix implicit attach on subscribe
Release/1.2.42
- Extracted HTTP calls and WebSocket listeners into a separate module. - Introduced an abstraction layer for easier implementation swapping.
Also add algorithm how to add new engine in the `CONTRIBUTING.md` guide
chore: rearrange code before refactoring
chore: update gradle wrapper
refactor: decouple HTTP and WebSocket engines
feat: OkHttp implementation for making HTTP calls and WebSocket connections
feat: introduced retry rules for flaky android push tests
…verage - Added extensive unit tests for LiveCounterManager tombstone serial handling - Enhanced LiveMapManagerTest with comprehensive tombstone serial scenarios - Updated DefaultLiveCounterTest and DefaultLiveMapTest for tombstone serial validation - Implemented thorough test coverage for server-provided tombstone serial functionality
- Added ObjectsCallback interface replacing generic Callback for Live Objects operations - Updated LiveObjects interface to extend ObjectsStateChange and use ObjectsCallback - Refactored LiveCounter and LiveMap async methods to use ObjectsCallback instead of Callback - Added comprehensive Javadoc for ObjectsCallback with operation-specific guidance
…alue union type - Added DefaultLiveObjectsTest with 187 lines of comprehensive Live Objects integration tests - Implemented complete integration test suite covering getRoot functionality - Enhanced test coverage for Objects state management and synchronization - Added integration tests for ObjectsCallback interface and async operations - Completed comprehensive test coverage for all Live Objects core functionality
- Enhanced ObjectIdTest with testFromInitialValue test for object initialization - Added new test methods to UtilsTest for realtime operation utilities - Updated ObjectMessageSizeTest with realtime write operation size calculations
[ECO-5426][LiveObjects] Implement object sync / operation
…ored [ECO-5076][LiveObjects] Implement getters for objects, map and counter
…efactored [ECO-5458][LiveObjects] Implement object subscriptions
…one-serial-refactored [ECO-5447][LiveObjects] Use server-provided timestamp to sweep old tombstones
…rite-api-refactored [ECO-5482][LiveObjects] Implement realtime write API
[ECO-5383][LiveObjects] Enable maven publish
- Adjusted channel state checks prior to channel modes for read and write objects operations - Added getChannel method to adapter interface, added relevant ensureAttached method with relevant implementation
…lpers - Removed unnecessary implementation from Adapter, made it clean - Updated unit tests/mocks accordingly
…s prefix - Renamed LiveObjects interface to RealtimeObjects - Removed Live prefix from other interfaces, kept them with Objects* - Removed use of liveobject keyword from the library since its reserved for business use case
and RealtimeChannel classes
[ECO-5517] Implement getRoot implicit attach
…ive-objects` module live-objects can be used both with ably-java and ably-android, making dependency `compileOnly` we prevent adding specific module (ably-java or ably-android) to the classpath
[LiveObject] Refactor/rename liveobjects classes
chore[live-objects]: change `:java` dependency to `compileOnly` in `live-objects` module
5a33153 to
2c36548
Compare
|
LGTM |
ssahu
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync Upstream Main
Summary
This PR syncs the latest changes from the upstream ably-java repository into the HubSpot fork.
Changes
2c365487Note:
The fatJar task was added to resolve dependency conflicts with the hubspot managed dependencies. The specific exclusions in the filter are:
This creates a single executable JAR with all runtime dependencies while avoiding classpath conflicts from these problematic dependencies.
Type of Change
Testing
java.jarandjava-sources.jar)Notes
This sync brings the HubSpot fork up to date with the latest upstream changes. No functional changes were made as part of this sync.