improvements to trivial group #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 806836eb-8793-4452-af1a-11ceb893c83a -->
This was referenced Jan 4, 2025
Signed-off-by: Ali Caglayan <[email protected]>
jdchristensen
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, we rename
IsTrivialSubgrouptoIsTrivialGroup.maximal_subgroupis now a coercion, which means we can writeIsTrivialGroup Gfor a subgroupG, therefore dropping thesubseemed appropriate.Next we simplify the definition by only requiring a map into the trivial group, which corresponds to a subgroup inclusion. The reverse inclusion is trivial, and is stated for completeness. It didn't need to be part of the data.
Finally we show that a group is trivial iff it is isomorphic to the trivial group. Seems negligible on paper, but some details need to be provided.